Peter Memishian wrote:
>  > >  > >  >  http://cr.opensolaris.org/~yun/webrev_dlmgmtd/
>  >
>  > Thanks. I updated the webrev.
> 
> The GID_DLADM definition makes me uneasy, as there really isn't a dladm
> group (and to my view, the GID_XXX values should correspond to the value
> you'd get by looking up XXX via getgrnam()).  I'd rather callers just
> directly use GID_SYS, than maintain an illusion that GID_DLADM exists.
> 
> Other than that and the blank line at sys/param.h:87, looks good.
> 
Changed. Thanks!
- Cathy

Reply via email to