On Mon, 18 Mar 2024 12:25:24 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits since the last revision:
>>
>> - used PassFailJFrame.logArea()
>> - Merge branch 'master' into WheelRotation_8328190
>> - ordering of imports
>> - whitespace removed
>> - default timeout used
>> - @requires tag
>> - title change
>> - converted test to main
>> - delete .html file
>> - moved test file
>
> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 55:
>
>> 53:
>> 54: public static void main (String[] args) throws Exception {
>> 55: PassFailJFrame.builder()
>
> OS check can be added.
> https://github.com/openjdk/jdk/pull/18233#discussion_r1525227378
It can be added, but I see no reason to do so.
It may be helpful for tests that can be run standalone (that don't respect the
jtreg tags and depend on some other jtreg libraries), but for this one the only
easy way to run it is through jtreg, so the `@requires (os.family ==
"windows")` is sufficient.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1528802959
