On Tue, 19 Mar 2024 17:56:25 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor changes > > test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 49: > >> 47: below the instruction window. >> 48: Please make sure that some of the messages have non-zero >> 'wheelRotation' value, >> 49: and also check if the test works OK if the mouse wheel is >> rotated very slow. > > Shall we increase the width of the instruction window so that less horizontal > scrolling is needed? > > The test can actually verify the condition without help from the user. The > handler for `MouseWheelListener` could well look into the `MouseWheelEvent` > and verify _automatically_ if `scrollType=WHEEL_UNIT_SCROLL` and there are > any events with `wheelRotation=1` (or rather `wheelRotation!=0`). > > You can even `forcePass` the test as soon as you detected few events which > satisfy the condition. > > If you don't see events with `scrollType=WHEEL_UNIT_SCROLL`, then the mouse > doesn't support high-resolution scrolling. Sounds good, test can be made semi-automatic. How long or many MouseWheelEvents do we check ? Probably 10-15 would be a good number? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1530874171
