On Tue, 19 Mar 2024 18:01:01 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor changes > > test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 32: > >> 30: * @test >> 31: * @bug 6730447 >> 32: * @summary [Win] To verify the support for high resolution mouse wheel >> on Windows. > > This could be applicable to other platforms too, even though > [JDK-6730447](https://bugs.openjdk.org/browse/JDK-6730447) and > [JDK-6524352](https://bugs.openjdk.org/browse/JDK-6524352) are reported > against Windows only. It could be than support for high-resolution mouse > wheel was implemented on macOS earlier than on Windows. I have remove @requires tag and the test is extended to all platforms. > test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 49: > >> 47: below the instruction window. >> 48: Please make sure that some of the messages have non-zero >> 'wheelRotation' value, >> 49: and also check if the test works OK if the mouse wheel is >> rotated very slow. > > Shall we increase the width of the instruction window so that less horizontal > scrolling is needed? > > The test can actually verify the condition without help from the user. The > handler for `MouseWheelListener` could well look into the `MouseWheelEvent` > and verify _automatically_ if `scrollType=WHEEL_UNIT_SCROLL` and there are > any events with `wheelRotation=1` (or rather `wheelRotation!=0`). > > You can even `forcePass` the test as soon as you detected few events which > satisfy the condition. > > If you don't see events with `scrollType=WHEEL_UNIT_SCROLL`, then the mouse > doesn't support high-resolution scrolling. @aivanov-jdk Semi-automated the test, it now passes when 5 or more MouseWheelEvent of type: scrollType=WHEEL_UNIT_SCROLL & wheelRotation != 0 is recorded. Updated the instructions accordingly. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1531080738 PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1531078089
