On Tue, 19 Mar 2024 12:13:43 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>> I agree with @azvegint, since it has @requires check in jtreg and the test 
>> will mainly be run using jtreg framework , the OS check is not strictly 
>> required.
>
> Fair enough.

I agree. Adding an explicit OS check adds one more dependency on a test library.

It's not that hard to run a test with `PassFailJFrame` without jtreg, however, 
it's not as simple as `java <path>/<testname>.java`. Any way, if you run on a 
non-Windows, you may get unexpected result.

Is the test not applicable to other platforms? macOS also supports high-res 
mice, trackpad on a MacBook is high-res too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1530828760

Reply via email to