On Thu, 7 Mar 2024 09:27:10 GMT, Renjith Kannath Pariyangad <rkannathp...@openjdk.org> wrote:
>> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know your suggestions. >> >> Regards, >> Renjith > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one additional commit since the last revision: > > Updated instructions Changes requested by aivanov (Reviewer). test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 230: > 228: "left margins will be shrunk if they are too great for > the adjusted \n" + > 229: "imageable area to fit at that position. They will > shrink by the minimum\n" + > 230: "needed to accomodate the imageable area.\n \n \n" + Suggestion: "needed to accommodate the imageable area.\n \n \n" + Typo to fix. ------------- PR Review: https://git.openjdk.org/jdk/pull/17607#pullrequestreview-1920127795 PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1542068572