On Mon, 1 Apr 2024 05:38:54 GMT, Renjith Kannath Pariyangad <rkannathp...@openjdk.org> wrote:
>> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know your suggestions. >> >> Regards, >> Renjith > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one additional commit since the last revision: > > Optimized switch case Changes requested by aivanov (Reviewer). test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 67: > 65: > 66: private static String GetOrientation(int o) > 67: { Follow Java Coding Style: Suggestion: private static String getOrientation(int o) { Method names start with lower-case letter; the opening brace is on the same line as the construct it opens. ------------- PR Review: https://git.openjdk.org/jdk/pull/17607#pullrequestreview-1973401767 PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1547631488