On Wed, 6 Mar 2024 05:08:08 GMT, Renjith Kannath Pariyangad <rkannathp...@openjdk.org> wrote:
>> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know your suggestions. >> >> Regards, >> Renjith > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one additional commit since the last revision: > > Added Override test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 90: > 88: case PageFormat.REVERSE_LANDSCAPE -> > "REVERSE_LANDSCAPE"; > 89: default -> "<invalid>"; > 90: })); You still have this code twice in this file. Create a helper method and re-use the functionality instead of having two identical copies, as [I suggested previously](https://github.com/openjdk/jdk/pull/17607#discussion_r1487928320). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1514719472
