On Tue, 2 Apr 2024 11:19:15 GMT, Renjith Kannath Pariyangad
<rkannathp...@openjdk.org> wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know your suggestions.
>>
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Force fail added for user cancel case
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 66:
> 64: Label myOrientationLabel;
> 65:
> 66: private static String GetOrientation(int o) {
Suggestion:
private static String getOrientation(int o) {
The method name should start with *a lower-case letter*. And the call sites
need updating too.
-------------
PR Review: https://git.openjdk.org/jdk/pull/17607#pullrequestreview-1973469667
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1547674525
