On Mon, 20 May 2024 06:30:06 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make OutputBin class sealed
>
> src/java.desktop/share/classes/javax/print/attribute/standard/OutputBin.java
> line 184:
>
>> 182: */
>> 183: @Override
>> 184: public final Class<? extends Attribute> getCategory() {
>
> It does not seem this PR supports
> `output-bin-default` mentioned in the IPP doc, which will be returned via
> [getDefaultAttributeValue](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/print/PrintService.html#getDefaultAttributeValue(java.lang.Class))([Class](https://docs.oracle.com/en/java/javase/22/docs/api/java.base/java/lang/Class.html)<?
> extends
> [Attribute](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/print/attribute/Attribute.html)>
> category)?
> If not, what this API will return?
Also, as per IPP document
>
> When returning the values of the
> associated “output-bin-supported” attribute, the values returned MAY depend
> on the user issuing the Get-
> Printer-Attributes operation
>
I think, we are supposed to return the supported output-bins when user calls
[getSupportedAttributeValues](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/print/PrintService.html#getSupportedAttributeValues(java.lang.Class,javax.print.DocFlavor,javax.print.attribute.AttributeSet))([Class](https://docs.oracle.com/en/java/javase/22/docs/api/java.base/java/lang/Class.html)<?
extends
[Attribute](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/print/attribute/Attribute.html)>
category,
[DocFlavor](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/print/DocFlavor.html)
flavor,
[AttributeSet](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/print/attribute/AttributeSet.html)
attributes)
which it seems is not done..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1606324503
