On Wed, 29 May 2024 20:20:00 GMT, Alexander Scherbatiy <[email protected]> wrote:
>> Actually it is not clear for me which maximum N should be used for these >> constants. >> Should only `tray-1`, `tray-2`, and `tray-3` be added, or should there be >> constants `tray-1` ... `tray-5` or even more? > > I updated the `PrintService.isAttributeValueSupported()` method that it > always returns true for CustomOutputBin class and returns true for an > OutputBin constant only if its original name (ipp case) or the name without > `-` sign (cups case) equals to one of the supported output bin choice name. What I understood is, it is acceptable to identify or get tray-1, tray-2, tray-3 name instead of descriptive names like TOP, MIDDLE, BOTTOM respectively etc so as such it can support upto 11 trays ie FROM TOP till LARGE_CAPACITY but am not sure if it is to be added in addition or in-place of the descriptive names? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1619889088
