On Thu, 30 May 2024 20:37:51 GMT, Alexander Scherbatiy <alex...@openjdk.org> wrote:
>> What I understood is, it is acceptable to identify or get >> tray-1, tray-2, tray-3 name >> instead of descriptive names like >> TOP, MIDDLE, BOTTOM respectively etc >> so as such it can support upto 11 trays ie FROM TOP till LARGE_CAPACITY >> >> but am not sure if it is to be added in addition or in-place of the >> descriptive names? > > It is easy to add new constants to a public API but there is no way to remove > them. > OutpuBin constants work only if they are listed among the supported output > bins. > There is always a way to lookup `tray-n` output bin through the supported > ones and it would work in the same way if it was included as a predefined > constant. If it's only about adding tray-1 to tray-11 in the above list and not about whole lot of changes in other areas, so that supported list contains those "tray-N" values, I guess we should add them.. I guess isSupportedAttributedValues(tray-N) will not return false in that case.. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1621817791
