On Tue, 27 Aug 2024 06:04:47 GMT, Tejesh R <t...@openjdk.org> wrote: > Test failed intermittently on particular host. Though analysis pointed out to > a test frame at left top on that host, I've updated the test for further > stabilizing it. Two things done here: > 1. Move the frame to center of the screen rather than left top. > 2. Added tolerance checks for color comparison - this is based on analysis > reports where the image didn't had exact black color which is supposed to be. > So like other test cases, providing some tolerance for comparison.
test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 51: > 49: private static BufferedImage imageAfterChecked; > 50: private static volatile boolean checkmarkFound = false; > 51: private static final int TOLERANCE = 10; Is this tolerance needed for the test to pass? Would just moving the test to the center be enough for this fix? I agree with Abhishek that there might be false positives, particularly with color profiles where the test should fail but would pass with this change, especially since this is a ui scaling test. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1735323692
