On Tue, 27 Aug 2024 06:04:47 GMT, Tejesh R <t...@openjdk.org> wrote: > Test failed intermittently on particular host. Though analysis pointed out to > a test frame at left top on that host, I've updated the test for further > stabilizing it. Two things done here: > 1. Move the frame to center of the screen rather than left top. > 2. Added tolerance checks for color comparison - this is based on analysis > reports where the image didn't had exact black color which is supposed to be. > So like other test cases, providing some tolerance for comparison.
As @kumarabhi006 and @alisenchung pointed out I think there might be cases of false positives with high tolerance values. Following are couple of suggestions: - Check if a lower more optimal value of tolerance works. - Continue pixel compare till you encounter 4-5 pixels of the expected color (with tolerance) - Adding debug logs to see which colors pass the criteria. ------------- PR Review: https://git.openjdk.org/jdk/pull/20723#pullrequestreview-2273237979
