On Fri, 30 Aug 2024 18:22:56 GMT, Harshitha Onkar <[email protected]> wrote:
>> Test failed intermittently on particular host. Though analysis pointed out
>> to a test frame at left top on that host, I've updated the test for further
>> stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rather than left top.
>> 2. Added tolerance checks for color comparison - this is based on analysis
>> reports where the image didn't had exact black color which is supposed to
>> be. So like other test cases, providing some tolerance for comparison.
>
> test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 80:
>
>> 78: if (compareColor(pixelColor)) {
>> 79: checkmarkFound = true;
>> 80: break check;
>
> @TejeshR13 Logging the pixelColor inside the if block can be useful for
> debugging purpose.
> You could add a counter variable here and continue until 4-5 pixels match the
> criteria.
On failure we are saving the image, I don't think logging pixelColor would add
any additional help in debugging here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1740333346
