On Tue, 27 Aug 2024 06:04:47 GMT, Tejesh R <[email protected]> wrote:
> Test failed intermittently on particular host. Though analysis pointed out to
> a test frame at left top on that host, I've updated the test for further
> stabilizing it. Two things done here:
> 1. Move the frame to center of the screen rather than left top.
> 2. Added tolerance checks for color comparison - this is based on analysis
> reports where the image didn't had exact black color which is supposed to be.
> So like other test cases, providing some tolerance for comparison.
test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 80:
> 78: if (compareColor(pixelColor)) {
> 79: checkmarkFound = true;
> 80: break check;
@TejeshR13 Logging the pixelColor inside the if block can be useful for
debugging purpose.
You could add a counter variable here and continue until 4-5 pixels match the
criteria.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20723#discussion_r1739229296
