On Wed, 30 Oct 2024 11:03:18 GMT, Tejesh R <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove some redundant code
>
> test/jdk/java/awt/print/Dialog/PrintDlgPageable.java line 54:
>
>> 52: }
>> 53: arg = Integer.parseInt(args[0]);
>> 54: PrintDlgPageable pd = new PrintDlgPageable();
>
> `pd` unused.
ok
> test/jdk/java/awt/print/Dialog/PrintDlgPageable.java line 97:
>
>> 95:
>> 96: //printable interface
>> 97: public int print(Graphics g, PageFormat pf, int pi) throws
>> PrinterException {
>
> `throws PrinterException` not required.
it is required...See java.awt.print.Printable spec
> test/jdk/javax/print/StreamPrintingOrientation.java line 52:
>
>> 50:
>> 51: public class StreamPrintingOrientation implements Printable {
>> 52: public StreamPrintingOrientation() {
>
> Can remove this constructor.
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21780#discussion_r1822455014
PR Review Comment: https://git.openjdk.org/jdk/pull/21780#discussion_r1822456357
PR Review Comment: https://git.openjdk.org/jdk/pull/21780#discussion_r1822456575
