On Mon, 4 Nov 2024 09:26:44 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   minor formatting
>
> test/jdk/java/awt/print/Dialog/PrintDlgPageable.java line 123:
> 
>> 121:             pf.setOrientation(PageFormat.PORTRAIT);
>> 122:             PassFailJFrame.log("Orientation returned from Pageable " + 
>> findOrientation(pf.getOrientation()));
>> 123:             return pf;
> 
> duplicate code...can be moved outside of `if..else` block.

Removed the whole method as logging for printing is not needed for this 
PageRange check test

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21780#discussion_r1827455762

Reply via email to