On Mon, 4 Nov 2024 09:51:10 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Couple of printing tests dont have "public" modifier so CI testing fails to >> run this test citing IllegalAccessException. >> Fix is made to made the test class public. >> >> Additionally, modified PrintDlgPageable.java to use PFJ and made >> StreamPrintingOrientation.java automated. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > minor formatting LGTM except minor change suggested. test/jdk/javax/print/StreamPrintingOrientation.java line 59: > 57: PrintService service = null; > 58: > 59: FileOutputStream fos = null; Can be moved to L64. ------------- Marked as reviewed by abhiscxk (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21780#pullrequestreview-2412617716 PR Review Comment: https://git.openjdk.org/jdk/pull/21780#discussion_r1827462671
