On Wed, 5 Feb 2025 07:13:33 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> test/jdk/javax/accessibility/TestJCheckBoxToggleAccessibility.java line 87:
>>
>>> 85:
>>> 86: Press Pass if you are able to hear correct VoiceOver
>>> announcements and
>>> 87: able to see the correct screen magnifier behaviour. """;
>>
>> These long instructions may benefit from using HTML for formatting
>> instructions.
>
> Are you suggesting to change entire instruction set with HTML formatting ?
>
> I would appreciate if you add some sample changes. you are referring
Here's the sample that I used:
<details>
<summary>HTML code for instructions</summary>
String INSTRUCTIONS = """
<html><body>
<p><b>Testing with VoiceOver</b></p>
<ol>
<li>Start the VoiceOver application
(Press <kbd>Command</kbd> + <kbd>F5</kbd>)
<li>Click on the <i>Frame with CheckBox and ToggleButton</i>
window to move focus
<li>Press <kbd>Spacebar</kbd>
<li>VO should announce the checked state
<li>Press <kbd>Spacebar</kbd> again
<li>VO should announce the unchecked state
<li>Press <kbd>Tab</kbd> to move focus to <i>ToggleButton</i>
<li>Repeat steps 3 to 6 and listen the announcement
<li>If announcements are incorrect, press <b>Fail</b>
<li>Stop the VoiceOver application
(Press <kbd>Command</kbd> + <kbd>F5</kbd> again)
</ol>
<p><b>Testing with Screen Magnifier</b></p>
<ol style="margin-bottom: 0">
<li>Enable Screen magnifier on the Mac:
<b>System Settings</b> -> <b>Accessibility</b> ->
<b>Hover Text</b> -> <b>Enable Hover Text</b><br>
Default Hover Text Activation Modifier is <kbd>Command</kbd>
key.
<li>Move focus back to test application
<ul style="margin-bottom: 0">
<li>Test <i>CheckBox</i> states with Screen Magnifier
<ol style="list-style-type: lower-alpha; margin-top: 0;
margin-bottom: 0">
<li>Click on <i>CheckBox</i> to select it
<li>Press the <kbd>Command</kbd> key and
hover mouse over <i>CheckBox</i>
<li>CheckBox ticked state along with its label should
be magnified
<li>Keep the <kbd>Command</kbd> key pressed and
click <i>CheckBox</i> to deselect it
<li>CheckBox unticked state along with its label should
be magnified
<li>Release the <kbd>Command</kbd> key
<li>If Screen Magnifier behaviour is incorrect, press
<b>Fail</b>
</ol>
<li>Test <i>ToggleButton</i> states with Screen Magnifier
<ol style="list-style-type: lower-alpha; margin-top: 0;
margin-bottom: 0">
<li>Click on <i>ToggleButton</i> to select it
<li>Press the <kbd>Command</kbd> key and
hover mouse over <i>ToggleButton</i>
<li>Ticked state along with label should be magnified
<li>Keep the <kbd>Command</kbd> button pressed and
click <i>ToggleButton</i> to deselect it
<li>Unticked state along with its label should be
magnified
<li>Release the <kbd>Command</kbd> key
<li>If Screen Magnifier behaviour is incorrect, press
<b>Fail</b>
</ol>
</ul>
</ol>
<p>Press <b>Pass</b> if you are able to hear correct VoiceOver
announcements and
able to see the correct screen magnifier
behaviour.</p></body></html>""";
</details>
This gives the following look:
<img alt="Screenshot with the instruction text displayed in HTML"
src="https://github.com/user-attachments/assets/38146f37-c86c-4e14-bc9f-98ae384c17ac";
/>
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23436#discussion_r1953131477
