On Wed, 5 Feb 2025 07:04:21 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> VoiceOver doesn't announce the _untick state_ when Checkbox is `deselected` >> using **space** key. When CheckBox is deselected, the state change is not >> notified to a11y client (VoiceOver) and so the state is not announced by VO. >> >> Screen Magnifier is also unable to magnify the unchecked state of JCheckBox >> due to same reason and is captured as separate bug >> [JDK-8345728](https://bugs.openjdk.org/browse/JDK-8345728). >> >> Proposed fix is to send the state change notification to a11y client when >> checkbox is deselected, this resolves the problem for VoiceOver and Screen >> Magnifier. >> >> Similar issue observed for JToggleButton. So, I extended the fix for >> JToggleButton as well. >> >> The proposed change can be verified the manual test in the PR. >> >> CI pipeline testing is `OK`, link posted in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Condition evaluation simplified Looks good to me. ------------- Marked as reviewed by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23436#pullrequestreview-2612711918
