On Wed, 12 Feb 2025 16:32:18 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

> Tested with SwingSet2, and I can hear the difference in announcements.

Yes, I tested with SwingSet2 application and found the inconsistency in 
announcements. When we move between radio buttons with left / right arrow (one 
of the radio buttons is selected) then the announcements are not correct. 

> It looks the difference comes from the focus events: when the old button 
> loses focus, valueChanged isn't called currently, but if Objects.equals is 
> used, valueChanged gets called twice.

Yeah, valueChanged gets called twice and that seems the reason for inconsistent 
behaviour.

Thank you for carrying out the testing and provide your feedback.

> Let's keep the current behaviour, it's more reliable even though it looks 
> inconsistent.

I agree, functional behaviour should not be incorrect for the sake of code 
consistency.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23436#discussion_r1953068417

Reply via email to