> This adds support for parsing thumbnails in an APP1 Exif marker.
> 
> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In 
> that previous work the only additional meta info he parsed was the image 
> creation time; this PR similarly includes the same property. (I can't speak 
> to why he included that property, but it looks like he has a lot of 
> experience with ImageIO so I trust his judgment.)
> 
> ~~The test addresses the original images attached to the ticket plus a few 
> extra images I found on my computer that include unusual properties. 
> (Possibly those images are malformed, but if they exist in the wild and other 
> platforms support them then I'd prefer to support them too.)~~
> 
> The images used in this test are contributed by Brian and me.

Jeremy has updated the pull request incrementally with one additional commit 
since the last revision:

  8160327: trying to placate PR script
  
  Some github script is concluding:
  ```
  Errors
   ⚠️ Executable files are not allowed (file: 
test/jdk/javax/imageio/plugins/jpeg/JpegExifThumbnail/jfif_and_exif.jpg)
   ⚠️ Executable files are not allowed (file: 
test/jdk/javax/imageio/plugins/jpeg/JpegExifThumbnail/malicious_looping_IFD.jpg)
  ```
  
  I'm trying to figure what separates these files from the other JPGs. Maybe I 
need to use hyphens instead of underscores...? Let's check.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22898/files
  - new: https://git.openjdk.org/jdk/pull/22898/files/24b6feea..4445d6e9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22898&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22898&range=04-05

  Stats: 2 lines in 3 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/22898.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22898/head:pull/22898

PR: https://git.openjdk.org/jdk/pull/22898

Reply via email to