On Mon, 3 Mar 2025 19:38:56 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> I think I've finished all the pending edits I had in mind. >> >> Regarding ownership of images: >> One sample image comes from Brian, the rest come from me. >> >> A few questions remain on my end: >> >> 1. The PR bot somehow flagged two of the test jpg files as executables >> (which it describes as "Errors"). Any recommendations on how to placate this >> error? (Should I just zip the images together?) >> >> @bplb : >> 2. Do you still think a test case featuring an uncompressed RGB main image >> with a uncompressed RGB thumbnail is necessary? >> >> I'm not sure off the top of my head how to generate this kind of image. It >> seems to me like reading any thumbnail is completely insulated from reading >> the main image, so mixing and matching combinations of main images and >> thumbnails shouldn't be an issue. (?) >> >> 3. Should I add a test that includes an EXIF thumbnail followed by a JFIF >> thumbnail? You asked about (and the original ticket included) an image that >> featured a JFIF thumbnail followed by an EXIF thumbnail, and this PR now >> covers that test case. But I think the JFIF logic is stricter and will >> probably throw an exception if the EXIF thumbnail appears first. > > @mickleness Your source branch is very out of date (more than two months). > Can you merge in the latest upstream master? Thanks, @kevinrushforth, for the various comments. @mickleness, the merge should be no problem as, aside from the image archive, the diff from the webrev applies cleanly to the current master and builds without problems. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22898#issuecomment-2695407850
