On Mon, 24 Feb 2025 07:09:35 GMT, Jeremy <d...@openjdk.org> wrote: >> Jeremy has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8160327: replacing the "sony-d700" image >> >> The origins of that image were unknown, so we weren't sure if we had the >> rights to store it in the OpenJDK repo. >> >> I couldn't figure out how to create this kind of uncompressed thumbnail >> from an image editing app, so I spliced this new file together manually in a >> hex editor using the sony-d700 image as a blueprint. > > I think I've finished all the pending edits I had in mind. > > Regarding ownership of images: > One sample image comes from Brian, the rest come from me. > > A few questions remain on my end: > > 1. The PR bot somehow flagged two of the test jpg files as executables (which > it describes as "Errors"). Any recommendations on how to placate this error? > (Should I just zip the images together?) > > @bplb : > 2. Do you still think a test case featuring an uncompressed RGB main image > with a uncompressed RGB thumbnail is necessary? > > I'm not sure off the top of my head how to generate this kind of image. It > seems to me like reading any thumbnail is completely insulated from reading > the main image, so mixing and matching combinations of main images and > thumbnails shouldn't be an issue. (?) > > 3. Should I add a test that includes an EXIF thumbnail followed by a JFIF > thumbnail? You asked about (and the original ticket included) an image that > featured a JFIF thumbnail followed by an EXIF thumbnail, and this PR now > covers that test case. But I think the JFIF logic is stricter and will > probably throw an exception if the EXIF thumbnail appears first.
@mickleness Your source branch is very out of date (more than two months). Can you merge in the latest upstream master? ------------- PR Comment: https://git.openjdk.org/jdk/pull/22898#issuecomment-2695368442
