On Wed, 26 Feb 2025 09:23:47 GMT, Jeremy <d...@openjdk.org> wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time; this PR similarly includes the same property. (I can't speak >> to why he included that property, but it looks like he has a lot of >> experience with ImageIO so I trust his judgment.) >> >> ~~The test addresses the original images attached to the ticket plus a few >> extra images I found on my computer that include unusual properties. >> (Possibly those images are malformed, but if they exist in the wild and >> other platforms support them then I'd prefer to support them too.)~~ >> >> The images used in this test are contributed by Brian and me. > > Jeremy has updated the pull request incrementally with one additional commit > since the last revision: > > 8160327: trying to placate PR script > > The github script still classifies two of the sample jpgs as executable > files, which it classifies as errors.
I should add that image files for tests are an exception to the general rule that binary files should not be checked into the repo. Zip files are not. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22898#issuecomment-2695358120
