On Mon, 10 Mar 2025 19:28:24 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Jeremy Wood has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8351108: changing Error to Exception, adding javadoc >> >> This is partly in response to: >> https://github.com/openjdk/jdk/pull/23884#discussion_r1987733487 > > test/jdk/javax/imageio/plugins/jpeg/JpegWriterWriteNonOpaqueIndexColorModelTest.java > line 55: > >> 53: * @param name the name of the Transparency constant >> 54: * @param expectedWriteReturnValue the expected return value of >> <code>ImageIO.write(..)</code> >> 55: * @return true if <code>ImageIO.write(..) == >> expectedWriteReturnValue</code>, or false otherwise. > > Using `{@code ...}` is the preferred way to mark-up code fragments. > > Perhaps, a javadoc is too much… The method isn't that long, and it's rather > self-documenting. OK, the javadoc is removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23884#discussion_r1987981271
