On Fri, 26 Jun 2026 14:42:07 GMT, Alexey Ivanov <[email protected]> wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp line 2874:
>>
>>> 2872: }
>>> 2873: } else {
>>> 2874: swprintf(szVer + l, 128, L" (Windows 2000)");
>>
>> Should still be "Unknown"?
>>
>> Taking a step back though, I'd argue this whole method should be deleted.
>> It's only used in one log.fine statement in WToolkit, and the Windows
>> version information that it is logging is unimportant enough that it hasn't
>> been kept up to date since the start of the git history 19 years ago
>> (probably longer).
>
> Given that the only supported version of Windows is Windows 11 (and Windows
> 10 to some extent), yes, I'd rather remove the entire method.
I think we could replace that one usage
log.fine("Win version: " + getWindowsVersion());
with System.getProperty("os.version")
and get rid of this method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3483217892
