On Fri, 26 Jun 2026 13:17:29 GMT, Daniel Gredler <[email protected]> wrote:
>> The IS_WIN2000 macro checks for Windows major version number >= 5, see >> https://github.com/search?q=repo%3Aopenjdk%2Fjdk%20IS_WIN2000&type=code >> but we run for a long time on much higher Windows versions as a minimum. >> So the check is obsolete. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp line 2874: > >> 2872: } >> 2873: } else { >> 2874: swprintf(szVer + l, 128, L" (Windows 2000)"); > > Should still be "Unknown"? > > Taking a step back though, I'd argue this whole method should be deleted. > It's only used in one log.fine statement in WToolkit, and the Windows version > information that it is logging is unimportant enough that it hasn't been kept > up to date since the start of the git history 19 years ago (probably longer). Given that the only supported version of Windows is Windows 11 (and Windows 10 to some extent), yes, I'd rather remove the entire method. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3482117126
