On Mon, 29 Jun 2026 10:54:34 GMT, Matthias Baesken <[email protected]> wrote:
>> The IS_WIN2000 macro checks for Windows major version number >= 5, see >> https://github.com/search?q=repo%3Aopenjdk%2Fjdk%20IS_WIN2000&type=code >> but we run for a long time on much higher Windows versions as a minimum. >> So the check is obsolete. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Remove Java_sun_awt_windows_WToolkit_getWindowsVersion src/java.desktop/windows/native/libawt/windows/awt_DesktopProperties.cpp line 523: > 521: SetColorProperty(TEXT("win.menu.textColor"), > GetSysColor(COLOR_MENUTEXT)); > 522: // COLOR_MENUBAR is only defined on WindowsXP. Our binaries are > 523: // built on NT, hence the below ifdef. Overall looks good to me, with one caveat: these two lines document the `ifndef` below, so we should probably either remove both the comment and the `ifndef`, or keep them both. If the comment is accurate, all 5 lines should be deletable, but I can't confirm one way or the other from my own personal knowledge... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3499597558
