On Fri, 26 Jun 2026 14:54:20 GMT, Alexey Ivanov <[email protected]> wrote:
>> Isn't `IS_WIN2000` always true these days on all the Windows versions we >> could potentially start/run ? >> If it is, we can remove the check. >> But you are correct that the logic looks really strange now. >> And yeah Win XP is 5.1 here is the list of versions >> https://www.techthoughts.info/windows-version-numbers/ > > Yes, IS_WIN2000 is always true, but it was `&&` with `minor >= 1`. > > The condition was `(major >= 5 && minor >= 1) || (major > 5)`. > > But the updated version is wrong because it will return true if minor version > is 1 or greater irrespective of the major version. I removed the IS_WINXP macro. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3491047897
