On Fri, 26 Jun 2026 18:44:25 GMT, Alexey Ivanov <[email protected]> wrote:

>>> Also, is there a reason to keep IS_WINXP and IS_WINVISTA? These are also 
>>> older unsupported versions of Windows.
>> 
>> The fix will get bigger .. as these are both used in a number of places.
>> Unnecessarily perhaps (these days) but it does significantly expand the 
>> scope of the change .
>
> You're right,
> 
>> `IS_WINXP` is used in many places to determine menu bar colors, to handle 
>> subclassing default Windows controls.
> 
> as I mentioned a [JBS 
> comment](https://bugs.openjdk.org/browse/JDK-8289772?focusedId=14665584&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14665584)
>  for [JDK-8289772](https://bugs.openjdk.org/browse/JDK-8289772).

We can remove IS_WINVISTA, if this is desired, in another PR. Let's focus on 
IS_WINXP / IS_WIN2000 here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3513105952

Reply via email to