On Tue, 3 Nov 2026 19:37:03 GMT, Phil Race <[email protected]> wrote:

>> src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m line 49:
>> 
>>> 47: DECLARE_CLASS_ONLY(sjc_CPrinterDialog)
>>> 48: DECLARE_CLASS_ONLY(sjm_getNSPrintInfo)
>>> 49: DECLARE_CLASS_ONLY(sjm_printerJob)
>> 
>> Should it be DECLARE_CLASS_ONLY for sjm_getNSPrintInfo and sjm_printerJob?
>> Shouldn't it be DECLARE_METHOD_ONLY(sjm_getNSPrintInfo) and 
>> DECLARE_METHOD_ONLY(sjm_printerJob)?
>
> yes, fixed.

@prrace I was waiting for this comment to be resolved actually...As mentioned 
above, it seems to me that sjm_printerJob should be  DECLARE_FIELD_ONLY 
(instead of DECLARE_METHOD_ONLY) as it returns a GetObjectField via 
GET_FIELD_RETURN(sjm_printerJob, ...)...Let me know if it is not valid?!!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33481#discussion_r4534116519

Reply via email to