----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/#review17017 -----------------------------------------------------------
Ship it! Great work. Thanks for all the detailed information. - Nitin Mehta On Feb. 21, 2013, 10:01 a.m., deepti dohare wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7660/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2013, 10:01 a.m.) > > > Review request for cloudstack and Min Chen. > > > Description > ------- > > Currently no warning or confirmation is given or required to delete an iso > which is attached to a virtual machine. > > Fixing this issue using “force” delete option. > If an admin or a user deletes an ISO which is attached to a vm: > 1. Without force option; gives a warning that ISO is attached to vm “Failed > to delete iso. It is currently attached to virtual machine. Please detach it > before deleting”. > 2. With force option: first detach the ISO from all vms and then deletes the > ISO. > > > This addresses bug CLOUDSTACK-357. > > > Diffs > ----- > > server/src/com/cloud/storage/dao/VMTemplateHostDaoImpl.java 4d1ac02 > server/src/com/cloud/storage/download/DownloadMonitorImpl.java 6d3cf2a > server/src/com/cloud/template/HyervisorTemplateAdapter.java fe6bc2a > server/src/com/cloud/template/TemplateAdapterBase.java fa677ac > server/src/com/cloud/template/TemplateManagerImpl.java f9cf277 > server/src/com/cloud/vm/dao/UserVmDao.java 9fbcde3 > server/src/com/cloud/vm/dao/UserVmDaoImpl.java f2fc10b > > Diff: https://reviews.apache.org/r/7660/diff/ > > > Testing > ------- > > Verified locally. Tested for some cases: > > 1. Deleting iso(not attached to any vm) > 2. Deleting iso(attached to multiple vms in same domain) > 3. Deleting iso(attached to multiple vms in different domains) > > For admin/user > > > Thanks, > > deepti dohare > >
