Your patch doesn't apply Nitins-MacBook-Air:incubator-cloudstack nitinmehta$ git apply --whitespace=fix ../0001-CS-357-ISO-cannot-be-detached-when-it-is-deleted-fro.patch error: patch failed: server/src/com/cloud/storage/download/DownloadMonitorImpl.java:78 error: server/src/com/cloud/storage/download/DownloadMonitorImpl.java: patch does not apply error: patch failed: server/src/com/cloud/template/TemplateAdapterBase.java:76 error: server/src/com/cloud/template/TemplateAdapterBase.java: patch does not apply
From: Nitin Mehta <nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>> Reply-To: Nitin Mehta <nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>> To: Min Chen <min.c...@citrix.com<mailto:min.c...@citrix.com>> Cc: "cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org>" <cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org>>, Nitin Mehta <nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>>, Deepti Dohare <deepti.doh...@citrix.com<mailto:deepti.doh...@citrix.com>> Subject: Re: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/ Ship it! Great work. Thanks for all the detailed information. - Nitin On February 21st, 2013, 10:01 a.m., deepti dohare wrote: Review request for cloudstack and Min Chen. By deepti dohare. Updated Feb. 21, 2013, 10:01 a.m. Description Currently no warning or confirmation is given or required to delete an iso which is attached to a virtual machine. Fixing this issue using “force” delete option. If an admin or a user deletes an ISO which is attached to a vm: 1. Without force option; gives a warning that ISO is attached to vm “Failed to delete iso. It is currently attached to virtual machine. Please detach it before deleting”. 2. With force option: first detach the ISO from all vms and then deletes the ISO. Testing Verified locally. Tested for some cases: 1. Deleting iso(not attached to any vm) 2. Deleting iso(attached to multiple vms in same domain) 3. Deleting iso(attached to multiple vms in different domains) For admin/user Bugs: CLOUDSTACK-357 Diffs * server/src/com/cloud/storage/dao/VMTemplateHostDaoImpl.java (4d1ac02) * server/src/com/cloud/storage/download/DownloadMonitorImpl.java (6d3cf2a) * server/src/com/cloud/template/HyervisorTemplateAdapter.java (fe6bc2a) * server/src/com/cloud/template/TemplateAdapterBase.java (fa677ac) * server/src/com/cloud/template/TemplateManagerImpl.java (f9cf277) * server/src/com/cloud/vm/dao/UserVmDao.java (9fbcde3) * server/src/com/cloud/vm/dao/UserVmDaoImpl.java (f2fc10b) View Diff<https://reviews.apache.org/r/7660/diff/>
