Re: [cmake-developers] Patch pull request: support for shader entry point and shader model for Visual Studio FXCompiler custom tool build

Mon, 01 Dec 2014 07:06:18 -0800 

On 11/29/2014 12:51 AM, Cedric Perthuis wrote:
> So, here's a patch to address this. 
[snip]
> +    if (const char* se = sf->GetProperty("VS_SHADER_ENTRY_POINT"))
[snip]
> +    if (const char* sm = sf->GetProperty("VS_SHADER_MODEL"))

Thanks.  Here are some comments on the patch:

* Please update the documentation too.  See

   Help/manual/cmake-properties.7.rst
   Help/prop_sf/VS_SHADER_TYPE.rst

  for how VS_SHADER_TYPE is documented.

* Please update the test.  See

   Tests/VSWinStorePhone/CMakeLists.txt

  for current testing of VS_SHADER_TYPE.

Thanks,
-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to