Hi Cedric Thanks for the patch,
I had started adding a full set of shader property support on our fork: https://cmakems.codeplex.com/SourceControl/changeset/c5f9c207ee3490dda1e4c2a0eb647492b934fc11 I haven't asked to get this pulled in because with the number of options, it is probably better to add this support as a flag set instead of having a set of specific if statements. I haven't had a chance to complete this work though. -----Original Message----- From: Brad King [mailto:[email protected]] Sent: Monday, December 1, 2014 07:06 To: Cedric Perthuis Cc: [email protected]; Gilles Khouzam Subject: Re: [cmake-developers] Patch pull request: support for shader entry point and shader model for Visual Studio FXCompiler custom tool build On 11/29/2014 12:51 AM, Cedric Perthuis wrote: > So, here's a patch to address this. [snip] > + if (const char* se = sf->GetProperty("VS_SHADER_ENTRY_POINT")) [snip] > + if (const char* sm = sf->GetProperty("VS_SHADER_MODEL")) Thanks. Here are some comments on the patch: * Please update the documentation too. See Help/manual/cmake-properties.7.rst Help/prop_sf/VS_SHADER_TYPE.rst for how VS_SHADER_TYPE is documented. * Please update the test. See Tests/VSWinStorePhone/CMakeLists.txt for current testing of VS_SHADER_TYPE. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
