On 14 abr, 02:46, claudio canepa <[email protected]> wrote:
> On Tue, Apr 13, 2010 at 8:06 PM, claudio canepa <[email protected]> wrote:
>
> [sniped]
>
> > Will further investigate
commited r937 that (I hope!) fixes the issue.
Try please the relevant tests that the commit log (quoted below)
mentions, so we can close issue 136
Dangling thing:
I reverted the change made at r880, meant to fix context switch when
in fullscreen.
It was screwing big time in windows OS.
Questions:
1. should I reinsert those changes only for linux ?
2. what happens in a mac ?
Details:
look at the log below for description
Why:
in windows pyglet will send an 'on_deactivate' event when receiving
a 'WM_KILLFOCUS' from the OS, but the documentation for 'WM_KILLFOCUS'
tells:
"""
While processing this message, do not make any function calls that
display or activate a window. This causes the thread to yield control
and can cause the application to stop responding to messages
"""
I think the r880 changes, calling for window.set_fullscreen(False),
clashes with the advice.
svn log for r937:
"""
fixed: bad view size - position, bad virtual coords related to aspect
ratio
Related tests:
test_aspect_4-3_to_fullscreen.py
test_aspect_16-9_to_fullscreen.py
test_coords.py
History:
r937 : this revision - all test ok, whether they run in a 4:3 or 16:10
screen
r936 : retracted the changes done at r880, they broke view in windows
OS
r935 : added tests, modified test_coords to easy change window aspect
ratio
r934 : not working right, See thread
http://thread.gmane.org/gmane.comp.python.cocos2d.user/815
r880 : this change, meant to fix context switch when in fullscreen,
broke
visualization and window positioning for window OS.
Details:
windows OS, 4:3 monitor. After ctrl-f in
test_aspect_4-3_to_fullscreen.py:
1) I see yellow on the right and left, so it shows more x
than desired
2) The window is misplaced, ie the desktop shows
3) The window's client height is less than desired.
(should be same as screen height)
4) Previous CTRL-F behavior was toggle, now is always
'go_fullscreen'
r883 : positioning ok.
test_coords.py failed in a 4:3 monitor if starting with a 16:10
window and
doing ctrl-f
test_aspect_16-9.py failed in 4:3 monitor by missing left and
right sides when
doing ctrl-f
""
--
claudio
--
You received this message because you are subscribed to the Google Groups
"cocos2d discuss" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/cocos-discuss?hl=en.
