On Tue, Jul 6, 2010 at 11:07 PM, claudio canepa <[email protected]> wrote:
> > > So, my idea was to begin the final builds maybe two hours before, should > some problems arise. > > And, by the way, I ask all people to not change the cocos dir, except maybe > docstrings. > I can't possibly run all the tests another time (all working by r1004, for > the record) > > And if changing docstrings, render the docs and verify that the warnings / > errors count don't increase. > > There just so little time that I can't afford to uncheck tasks done. > > But it is coming well, I think. > > > I'm sorry, but will eliminate the addition in r1007 of method 'init' in Scene and Layer Reason: - broke samples/demo_transitions.py ( use arrow to select 'MoveInLTransition' , press enter: you get a traceback , albeit the cocos windows remains open, traceback is: D:\cocos_pristine\cocos_dev\cocos_doc\samples>demo_transitions.py Traceback (most recent call last): File "_ctypes/callbacks.c", line 295, in 'calling callback function' File "D:\hg_externals\pyglet-1.1.4\pyglet\window\win32\__init__.py", line 849, in _wnd_proc result = event_handler(msg, wParam, lParam) File "D:\hg_externals\pyglet-1.1.4\pyglet\window\win32\__init__.py", line 918, in _event_key self.dispatch_event(ev, symbol, modifiers) File "D:\hg_externals\pyglet-1.1.4\pyglet\window\__init__.py", line 1219, in d ispatch_event EventDispatcher.dispatch_event(self, *args) File "D:\hg_externals\pyglet-1.1.4\pyglet\event.py", line 340, in dispatch_eve nt if handler(*args): File "D:\cocos_pristine\cocos_dev\cocos_doc\samples\demo_transitions.py", line 66, in on_key_press 1.25) File "D:\cocos_pristine\cocos_dev\cocos_doc\samples\..\cocos\scenes\transition s.py", line 199, in __init__ super(MoveInLTransition, self ).__init__( *args, **kwargs) File "D:\cocos_pristine\cocos_dev\cocos_doc\samples\..\cocos\scenes\transition s.py", line 90, in __init__ super(TransitionScene, self).__init__() File "D:\cocos_pristine\cocos_dev\cocos_doc\samples\..\cocos\scene.py", line 1 07, in __init__ self.init() File "D:\cocos_pristine\cocos_dev\cocos_doc\samples\..\cocos\scenes\transition s.py", line 208, in init self.in_scene.position=(-width,0) AttributeError: 'MoveInLTransition' object has no attribute 'in_scene' ) A search for init produces a number of hits, possibly relevant ones in cocos\transitions.py , grid.py , tilegrid_actions.py Not related with this tracebacks, but there are others 'init' like in skeleton. So, the change broke things and seems to require some time to investigate. And until a few days cocos don't needed the added methods. I will retire both, in Layer and Scene ( Scene was done in r1007, Layer in r999 ) Call me overcautious to retire the change in Layer, but I think the addition needs more investigation. Sorry another time, but there is not much time. Please, if someone used this novel features, revise your code. -- claudio -- You received this message because you are subscribed to the Google Groups "cocos2d discuss" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/cocos-discuss?hl=en.
