Github user zellerh commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1612#discussion_r198222573
--- Diff: core/sql/executor/HdfsClient_JNI.h ---
@@ -171,7 +175,7 @@ class HdfsClient : public JavaObjectInterface
~HdfsClient();
static HdfsClient *newInstance(NAHeap *heap, ExHdfsScanStats *hdfsStats,
HDFS_Client_RetCode &retCode, int hdfsIoByteArraySizeInKB = 0);
static HdfsClient *getInstance();
- static void deleteInstance();
+ static void deleteInstance(HdfsClient *hdfsClient);
--- End diff --
Wouldn't it be more straightforward to just make this a non-static method
with no arguments?
---
