Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1612#discussion_r198243407
  
    --- Diff: core/sql/cli/SessionDefaults.cpp ---
    @@ -108,6 +108,7 @@ static const SessionDefaults::SessionDefaultMap 
sessionDefaultMap[] =
       SDEntry(SessionDefaults::SCHEMA,                   SCHEMA,               
      SessionDefaults::SDT_ASCII,          TRUE,    TRUE,  FALSE, FALSE),
       SDEntry(SessionDefaults::STATISTICS_VIEW_TYPE,     STATISTICS_VIEW_TYPE, 
      SessionDefaults::SDT_ASCII,          FALSE,   FALSE, TRUE,  TRUE),
       SDEntry(SessionDefaults::SUSPEND_LOGGING,          SUSPEND_LOGGING,      
      SessionDefaults::SDT_BOOLEAN,        FALSE,   FALSE, TRUE,  FALSE),
    +  SDEntry(SessionDefaults::USE_LIBHDFS,              USE_LIBHDFS,          
      SessionDefaults::SDT_BOOLEAN,        TRUE,    TRUE,  FALSE, FALSE),
    --- End diff --
    
    There is a need to access this CQD value in CLI. Hence, this CQD is 
converted into SSD. Setting this CQD converts into SSD automatically. See 
executor/ex_control.cpp. However, the settings of this SSD is such that it is 
not settable via SSD command. It can be set only via CQD.
    I would want USE_LIBHDFS to be settable in the defaults table. 
Unfortunately, the CQD set in the defaults table is not effective in CLI layer 
because it is not translated into SSD.  I would be fixing it in a separate PR 
if it is really needed at a future date.


---

Reply via email to