Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/257#discussion_r49483990
  
    --- Diff: core/sql/exp/exp_clause_derived.h ---
    @@ -1542,7 +1542,9 @@ enum conv_case_index {
       CONV_UTF8_F_UCS2_V                   =248,
     
       CONV_BLOB_BLOB                       =249,
    -  CONV_BLOB_ASCII_F                    =250
    +  CONV_BLOB_ASCII_F                    =250,
    +
    +  CONV_GBK_F_UTF8_V                    =251
    --- End diff --
    
    Do we also need a case for CONV_GBK_F_UTF8_F ? I am not quite how these 
case indexes work though. Maybe my question is if we have the user giving us 
GBK characters for a CHAR(N) UTF8 column, will it work with this change? Or is 
change applicable only when the target column in of type VARCHAR(N) UTF8 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to