Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/257#discussion_r49484259
--- Diff: core/sql/exp/exp_conv.cpp ---
@@ -9321,6 +9321,32 @@ convDoIt(char * source,
};
break;
+// gb2312 -> utf8
+ case CONV_GBK_F_UTF8_V:
+ {
+ char * targetbuf = new char[sourceLen*4+1];
+ size_t sl = sourceLen;
+ int convLen = gbkToUtf8( source, sl, targetbuf, sl*4);
+ int copyLen = 0;
+ if (convLen > 0) {
+ copyLen = (convLen< targetLen) ? convLen: targetLen;
--- End diff --
What if there is a real overflow, i.e. user has given a GBK value which
when converted to UTF8 exceeds the max varchar length? Will that be covered by
this error or is that checked in a different place? Some how I don't see max
length of target column in here...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
