Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/257#discussion_r49485546
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -1958,6 +1958,7 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS, "OFF"),
DDkwd__(HIVE_DEFAULT_CHARSET, (char *)SQLCHARSETSTRING_UTF8),
DD_____(HIVE_DEFAULT_SCHEMA, "HIVE"),
+ DD_____(HIVE_FILE_CHARSET, (char *)SQLCHARSETSTRING_UTF8),
--- End diff --
If we have to join two Hive tables, one in UTF8 and the other in GBK, I
suppose this method will have to be extended? Does Hive metadata store charset
info? If not would a comment next to the tablename help? This is just a minor
suggestion for something you may have already considered, not a request to add
this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
