Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/257#discussion_r49484840
--- Diff: core/sql/optimizer/SynthType.cpp ---
@@ -5207,6 +5207,18 @@ const NAType *Translate::synthesizeType()
err4106arg = SQLCHARSETSTRING_UTF8;
break;
+ case GBK_TO_UTF8:
+ if (translateSource->getCharSet() == CharInfo::GBK ||
translateSource->getCharSet() == CharInfo::UnknownCharSet )
+ charsetTarget = CharInfo::UTF8;
--- End diff --
Why do we have || CharInfo::UnknownCharSet here? I do not see it it in
neighbouring statements. This is just for my understanding.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
