potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP]
Multi-layered version of the docker image
URL: https://github.com/apache/airflow/pull/4543#discussion_r262158368
##########
File path: scripts/ci/kubernetes/docker/build.sh
##########
@@ -34,7 +34,7 @@ fi
echo "Airflow directory $AIRFLOW_ROOT"
echo "Airflow Docker directory $DIRNAME"
-if [[ ${PYTHON_VERSION} == '3' ]]; then
+if [[ ${PYTHON_VERSION} == 3* ]]; then
Review comment:
We can actually choose what set of python/kube/env combinations we want to
use and we will be able to choose what is the best matrix. Currently I added
both 3.5 and 3.6 - mostly because I know 3.6 vs. 3.5 might differ but also to
test how it works with more than 2/3 separation. But in the final version we
might deliberately choose what to run and we might decide not to run either 3.6
or 3.5 or whichever combo we want. I found that combining full matrix +
excludes is a bit easier and nicer than what we had before (see .travis.yml).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
