potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP]
Multi-layered version of the docker image
URL: https://github.com/apache/airflow/pull/4543#discussion_r262158782
##########
File path: setup.py
##########
@@ -69,7 +71,8 @@ def finalize_options(self):
pass
def run(self):
- os.system('rm -vrf ./build ./dist ./*.pyc ./*.tgz ./*.egg-info')
+ os.system('./docker_build.sh')
Review comment:
It's a big TODO here (above). It's not how it will look like eventually. I
have not yet looked at it but I am quite sure invoking docker in setup.py is a
bad idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
