potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP]
Multi-layered version of the docker image
URL: https://github.com/apache/airflow/pull/4543#discussion_r262511864
##########
File path: scripts/ci/kubernetes/docker/build.sh
##########
@@ -34,7 +34,7 @@ fi
echo "Airflow directory $AIRFLOW_ROOT"
echo "Airflow Docker directory $DIRNAME"
-if [[ ${PYTHON_VERSION} == '3' ]]; then
+if [[ ${PYTHON_VERSION} == 3* ]]; then
Review comment:
I will keep it in mind and change the scripts to allow x.y.z as well.
Currently I rely on having x.y version being 3 chars but i will make it more
general. It should be as easy as defining the right version to build in
DockerHub.
However 3.5.2 might be slightly problematic on its own.
There are no official python-slim images for 3.5.2 (only 3.5.6 from 3.5
series is available: https://hub.docker.com/_/python/ ) so we might have to
either prepare our own image or find reliable (and safe) source for that. There
are Docker files we can use from official python repo so that is not a big
problem, it's just a matter of putting that to a registry somewhere:
https://github.com/docker-library/python/blob/af2cf72d9c6c304d041c88db3e79242fd8c9ce60/3.5/stretch/slim/Dockerfile
I just checked default versions:
Xenial: 16.0.4 has 3.5.2 and 2.7.12
Bionic: 18.04 has 3.6.7 and 2.7.15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
