potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP] 
Multi-layered version of the docker image
URL: https://github.com/apache/airflow/pull/4543#discussion_r262503983
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -19,26 +19,30 @@
 sudo: true
 dist: trusty
 language: python
-python:
-  - "3.6"
 env:
   global:
-    - DOCKER_COMPOSE_VERSION=1.20.0
-    - TRAVIS_CACHE=$HOME/.travis_cache/
+    - DOCKER_COMPOSE_VERSION=1.23.2
   matrix:
-    - TOX_ENV=py27-backend_mysql-env_docker
-    - TOX_ENV=py27-backend_sqlite-env_docker
-    - TOX_ENV=py27-backend_postgres-env_docker
-    - TOX_ENV=py35-backend_mysql-env_docker PYTHON_VERSION=3
-    - TOX_ENV=py35-backend_sqlite-env_docker PYTHON_VERSION=3
-    - TOX_ENV=py35-backend_postgres-env_docker PYTHON_VERSION=3
-    - TOX_ENV=py27-backend_postgres-env_kubernetes KUBERNETES_VERSION=v1.9.0
-    - TOX_ENV=py35-backend_postgres-env_kubernetes KUBERNETES_VERSION=v1.10.0 
PYTHON_VERSION=3
-
+    - BACKEND=mysql ENV=docker
+    - BACKEND=postgres ENV=docker
+    - BACKEND=sqlite ENV=docker
+    - BACKEND=postgres ENV=kubernetes KUBERNETES_VERSION=v1.9.0
+    - BACKEND=postgres ENV=kubernetes KUBERNETES_VERSION=v1.10.0
+python:
+  - "3.6"
+  - "3.5"
 
 Review comment:
   I actually tried to use buildkit already and I have a flag to enable it :) 
https://github.com/apache/airflow/pull/4543/files#diff-14bdd6aac779ac93a185193b26ac4fd3R76
 - the problem with buildkit is that it's cache support does not work well with 
`docker build` command - buildkit uses different manifest and if you build+push 
using `docker build` such image is unusable for buildkit. You'd have to install 
and use buildkit directly (rather than rely on the experimental support in 
recent docker release)
   
   Support for this is coming in the near future and we should revisit it then. 
Also in the future (soon) version of Docker there will be "cache" type mount 
that we migt use for that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to