potiuk commented on a change in pull request #12082:
URL: https://github.com/apache/airflow/pull/12082#discussion_r519715121
##########
File path: .pre-commit-config.yaml
##########
@@ -438,6 +438,17 @@ repos:
files: ^airflow/www/.*\.(css|scss|sass)$
# Keep dependency versions in sync w/ airflow/www/package.json
additional_dependencies: ['[email protected]',
'[email protected]']
+ - id: version-sync
+ name: Version sync
+ files: ^airflow/version.py$|setup.py
+ entry: ./scripts/ci/pre_commit/pre_commit_sync_version.sh
+ language: system
Review comment:
I think yes. There were a few cases in various configurations where
dynamic loading of versions from setup.py did not work. I thin the number of
times It did not work for me (in pre-commits mainly but also when installing
packages and sources or when people will be installing virtualenv this might
cause various problems. I believe hard-coding the version and making sure it is
synchronized at the commit time removes the potential failure paths and clears
the path so that it "just works".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
